feat: Support pre-training and post-training callbacks in promote_docker_image workflow#4576
Open
RexBearIU wants to merge 1 commit into
Open
feat: Support pre-training and post-training callbacks in promote_docker_image workflow#4576RexBearIU wants to merge 1 commit into
RexBearIU wants to merge 1 commit into
Conversation
RexBearIU
requested review from
bvandermoon,
darisoy,
gobbleturk,
huytransformer,
igorts-git,
khatwanimohit,
parambole,
richjames0,
shralex and
xibinliu
as code owners
July 23, 2026 09:05
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
RexBearIU
force-pushed
the
user/jackyf/promote-docker-image-callbacks
branch
from
July 23, 2026 09:51
fc75273 to
18a0364
Compare
…ker_image workflow
RexBearIU
force-pushed
the
user/jackyf/promote-docker-image-callbacks
branch
from
July 23, 2026 09:53
18a0364 to
cecad28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
.github/workflows/promote_docker_image.ymlto handle both pre-training and post-training GitHub repository dispatch callbacks (airflow-dag-complete) independently.TEST_TYPE(pre_training/post_training) fromgithub.event.client_payloadin thehandle_resultstep.tag_docker_imagematrix strategy to matchtest_typeto its corresponding target Docker image:pre_training: promotesmaxtext_jax_nightlyandmaxtext_gpu_jax_nightly.post_training: promotesmaxtext_post_training_nightly.(github.event.client_payload.test_type == '' || github.event.client_payload.test_type == matrix.test_type)so that each callback promotes only its relevant Docker images, while preserving full backward compatibility iftest_typeis omitted.Tests
yamllint .github/workflows/promote_docker_image.yml.test_typematrix evaluation (pre_training->maxtext_jax_nightly,maxtext_gpu_jax_nightly;post_training->maxtext_post_training_nightly; empty -> all images).Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.